Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove packaging used for obsolete version check #289

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

deronnax
Copy link
Contributor

what it used for could be done without, but more importantly, pytest-1.14 was almost released 9 years ago in January 2016, there is no chance a recent install of pytest-sugar has it.
I tried and installed pytest-xdist 1.14 on a pytest 7 install and pytest would not even launch.
So it's safe to assume pytest-xdist will always be (way) more recent than 1.14.
It saves few kb at install size and few secs at install time.

@auvipy auvipy self-requested a review November 13, 2024 21:46
Copy link
Collaborator

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please check the failing build?

@deronnax deronnax force-pushed the remove-packaging-dep branch from 6a67610 to c123be0 Compare November 14, 2024 10:04
@deronnax
Copy link
Contributor Author

sure. Here you go. Tested locally

@justinmayer justinmayer changed the title remove 'packaging' package Remove packaging used for obsolete version check Nov 14, 2024
Copy link
Collaborator

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these improvements, Mathieu 👍

@justinmayer justinmayer merged commit 3c86a5c into Teemu:main Nov 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants